improve: enhance moc-agent#572
Merged
Merged
Conversation
- Remove all hardcoded absolute paths (/Users/cam/VAULT01/...) and replace with relative paths rooted at ./ - Replace VAULT01-specific references with generic vault terminology - Add model: sonnet field to frontmatter - Add Grep and Edit to tools list; remove redundant LS - Expand description with 3 concrete <example>/<commentary> blocks - Add Native Fallback Workflow using Glob+Grep (no external script dependency) - Make Script-Assisted Workflow optional with clear instructions to run from vault root - Add MOC Hierarchy section explaining LYT three-tier system (Home/Topic/Sub-MOC) - Add optional Dataview block to MOC template with note to remove if plugin absent - Add vault-structure validation guidance before writing MOCs Automated review cycle | Co-Authored-By: Claude Code <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
review-pending
Contributor
👋 Thanks for contributing, @davila7!This PR touches What happens next
While you wait
This is an automated message. No action is required from you right now — a maintainer will review soon. |
Contributor
|
| Metric | Count |
|---|---|
| Total Components | 763 |
| ✅ Passed | 360 |
| ❌ Failed | 403 |
| 1005 |
❌ Failed Components (Top 5)
| Component | Errors | Warnings | Score |
|---|---|---|---|
vercel-edge-function |
3 | 4 | 81/100 |
prompt-engineer |
2 | 0 | 90/100 |
neon-expert |
2 | 2 | 88/100 |
agent-overview |
2 | 1 | 89/100 |
unused-code-cleaner |
2 | 1 | 89/100 |
...and 398 more failed component(s)
📊 View Full Report for detailed error messages and all components
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cli-tool/components/agents/obsidian-ops-team/moc-agent.md">
<violation number="1" location="cli-tool/components/agents/obsidian-ops-team/moc-agent.md:80">
P2: Custom agent: **Component Reviewer**
Nested fenced code blocks break the MOC template example and make the instructions/rendered template misleading.</violation>
<violation number="2" location="cli-tool/components/agents/obsidian-ops-team/moc-agent.md:97">
P1: The fallback workflow doesn't actually detect missing MOCs or orphans; it only enumerates files/directories.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -1,42 +1,53 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
P1: The fallback workflow doesn't actually detect missing MOCs or orphans; it only enumerates files/directories.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At cli-tool/components/agents/obsidian-ops-team/moc-agent.md, line 97:
<comment>The fallback workflow doesn't actually detect missing MOCs or orphans; it only enumerates files/directories.</comment>
<file context>
@@ -62,50 +73,69 @@ Brief description of this knowledge domain.
+glob "./map-of-content/MOC - *.md"
+
+# 2. Find directories that have notes but no MOC
+glob "./**/*.md" | grep -v "map-of-content" | xargs -I{} dirname {} | sort -u
+
+# 3. Find notes not linked from any MOC (candidate orphans)
</file context>
| - [[Related MOC 2]] | ||
|
|
||
| <!-- Optional: remove if Dataview plugin is not installed --> | ||
| ```dataview |
Contributor
There was a problem hiding this comment.
P2: Custom agent: Component Reviewer
Nested fenced code blocks break the MOC template example and make the instructions/rendered template misleading.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At cli-tool/components/agents/obsidian-ops-team/moc-agent.md, line 80:
<comment>Nested fenced code blocks break the MOC template example and make the instructions/rendered template misleading.</comment>
<file context>
@@ -62,50 +73,69 @@ Brief description of this knowledge domain.
-- [[Related MOC 2]]
+
+<!-- Optional: remove if Dataview plugin is not installed -->
+```dataview
+LIST
+FROM #[relevant-tag]
</file context>
davila7
added a commit
that referenced
this pull request
May 7, 2026
Reflects merged improvements to cli-tool/components/agents/obsidian-ops-team/moc-agent.md. Automated by pr-verification cycle | Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Component Improvement
Changes
/Users/cam/VAULT01/System_Files/Scripts/moc_generator.py) — replaced with relative paths rooted at./VAULT01vault-specific references throughout body with generic vault terminologymodel: sonnetto YAML frontmatterGrepandEditto tools list; removed redundantLSdescriptionfield with 3 concrete<example>/<commentary>blocks matching project conventionsResearch Summary
The original component had 4 occurrences of a hardcoded absolute path (
/Users/cam/VAULT01/...), vault-specific naming (VAULT01), nomodelfield, no<example>blocks in the description, and a hard dependency on an external Python script that may not exist. The improved version is self-contained, generic, and follows the project's component standards.Validation
Automated review cycle by Component Improvement Loop
Summary by cubic
Make
moc-agentportable and self‑contained by removing absolute paths, generalizing vault references, and adding a script‑free fallback workflow. This standardizes MOC creation and updates across vaults.cli-tool/components/); updatedagents/obsidian-ops-team/moc-agent.mdVAULT01mentions; now uses./and generic vault termsmodel: sonnet; addedGrepandEdit; removed redundantLSGlob+Grep; made script-assisted flow optional; improved template (LYT hierarchy,Related MOCs, optional Dataview)Written for commit d1cfd50. Summary will update on new commits.